Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the batch_size parameter in the call to bulk_geocode #1666

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Removed the batch_size parameter in the call to bulk_geocode #1666

merged 1 commit into from
Jul 21, 2020

Conversation

antoniocarlon
Copy link
Contributor

@antoniocarlon antoniocarlon commented Jul 21, 2020 •
edited
Loading

Removed the batch_size parameter in the call to cdb_dataservices_client.cdb_bulk_geocode_street_point
Removed BATCH_SIZE from geocoding_constants.py

https://app.clubhouse.io/cartoteam/story/91890/sociallydetermined-onprem-user-can-t-geocode-in-cf-due-to-batch-size-must-be-lower-than-error

simon-contreras-deel
simon-contreras-deel approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@simon-contreras-deel simon-contreras-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me. From docs:

If not specified, it defaults to the maximum size available to the user, which is typically the best option, performance-wise.

@antoniocarlon antoniocarlon merged commit a5151cb into develop Jul 21, 2020
@antoniocarlon antoniocarlon deleted the feature/ch91890/sociallydetermined-onprem-user-can-t-geocode branch July 21, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-contreras-deel simon-contreras-deel simon-contreras-deel approved these changes

@josemazo josemazo Awaiting requested review from josemazo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoniocarlon @simon-contreras-deel