Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set a value for null geometries #1667

Conversation

antoniocarlon
Copy link
Contributor

Allow to set a value for null geometries.

The null_geom_value can be set when calling read_carto or when calling Geocoding.geocode. Example:

gc = Geocoding()
gdf, metadata = gc.geocode(df, street='address', city='city', country={'value': 'Spain'}, null_geom_value=BaseGeometry())

Created new tests in test_carto.py but not for test_geocoding.py as they are all skipped.

Related to https://app.clubhouse.io/cartoteam/story/94476/axa-group-error-performing-geopandas-operations-on-carto-dataset-because-of-none-values

Copy link
Contributor

@simon-contreras-deel simon-contreras-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@simon-contreras-deel
Copy link
Contributor

Just add a line to the changelog :)

@antoniocarlon antoniocarlon merged commit db4ae1e into develop Jul 23, 2020
@antoniocarlon antoniocarlon deleted the bug/ch94476/axa-group-error-performing-geopandas-operations branch July 23, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants