Check account disk quotas before writing using to_carto #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus89
requested changes
Aug 24, 2020
cartoframes/io/carto.py
Outdated
| @@ -89,6 +91,9 @@ def to_carto(dataframe, table_name, credentials=None, if_exists='fail', geom_col | |||
| uses the name of the index from the dataframe. | |||
| cartodbfy (bool, optional): convert the table to CARTO format. Default True. More info | |||
| `here <https://carto.com/developers/sql-api/guides/creating-tables/#create-tables>`. | |||
| ignore_quota_warning (bool, optional): ignore the warning of the possible quota exceeded | |||
| and force the upload. | |||
There was a problem hiding this comment.
I would add here Default False. to be consistent with the other descriptions
cartoframes/io/carto.py
Outdated
| @@ -114,6 +119,17 @@ def to_carto(dataframe, table_name, credentials=None, if_exists='fail', geom_col | |||
|
|
|||
| context_manager = ContextManager(credentials) | |||
|
|
|||
| if not ignore_quota_warning: | |||
There was a problem hiding this comment.
We could extract here me_data = context_manager.credentials.me_data to have a bit more readable code.
cartoframes/io/carto.py
Outdated
| if not ignore_quota_warning: | ||
| if context_manager.credentials.me_data is not None and context_manager.credentials.me_data.get('user_data'): | ||
| n = min(SAMPLE_ROWS_NUMBER, len(dataframe)) | ||
| dataframe_size = len(dataframe.sample(n=n).to_csv(header=False)) * len(dataframe) / n / CSV_TO_CARTO_RATIO |
There was a problem hiding this comment.
I would rename this dataframe_size to estimated_byte_size
cartoframes/io/carto.py
Outdated
| @@ -89,6 +91,9 @@ def to_carto(dataframe, table_name, credentials=None, if_exists='fail', geom_col | |||
| uses the name of the index from the dataframe. | |||
| cartodbfy (bool, optional): convert the table to CARTO format. Default True. More info | |||
| `here <https://carto.com/developers/sql-api/guides/creating-tables/#create-tables>`. | |||
| ignore_quota_warning (bool, optional): ignore the warning of the possible quota exceeded | |||
There was a problem hiding this comment.
I think we can use skip instead of ignore in the param name. What do you think?
Jesus89
reviewed
Aug 24, 2020
cartoframes/io/carto.py
Outdated
| n = min(SAMPLE_ROWS_NUMBER, len(dataframe)) | ||
| estimated_byte_size = len(dataframe.sample(n=n).to_csv(header=False)) * len(dataframe) \ | ||
| / n / CSV_TO_CARTO_RATIO | ||
| remaining_byte_quota = context_manager.credentials.me_data.get('user_data').get('remaining_byte_quota') |
|
@Jesus89 second CR round? |
Jesus89
approved these changes
Aug 24, 2020
Jesus89
deleted the
bug/ch93719/check-account-disk-quotas-before-writing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check account disk quotas before writing using
to_cartoNote: The PR is blocked until we decide what to do with in discussion here https://app.clubhouse.io/cartoteam/story/93719/check-account-disk-quotas-before-writing