Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploading extra the_geom fails #1677

Merged
merged 2 commits into from
Aug 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cartoframes/io/carto.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ def to_carto(dataframe, table_name, credentials=None, if_exists='fail', geom_col
gdf.set_geometry(dataframe.geometry.name, inplace=True)

if has_geometry(gdf):
if GEOM_COLUMN_NAME in gdf and dataframe.geometry.name != GEOM_COLUMN_NAME:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code must be moved right before the rename_geometry because otherwise, every time the user passes a geom_col and the df contains a column the_geom it fails.

gdf.drop(columns=[GEOM_COLUMN_NAME], inplace=True)

# Prepare geometry column for the upload
gdf.rename_geometry(GEOM_COLUMN_NAME, inplace=True)

Expand Down
36 changes: 36 additions & 0 deletions tests/unit/io/test_carto.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,42 @@ def test_to_carto(mocker):
assert norm_table_name == table_name


def test_to_carto_two_geom_columns(mocker):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add another test passing also geom_col. In this case:

to_carto(df, table_name, CREDENTIALS, geom_col='geometry')

# Given
table_name = '__table_name__'
cm_mock = mocker.patch.object(ContextManager, 'copy_from')
cm_mock.return_value = table_name
df = GeoDataFrame({'geometry': [Point([0, 0])],
'the_geom': '010100000000000000000000000000000000000000'})

# When
norm_table_name = to_carto(df, table_name, CREDENTIALS)

# Then
assert cm_mock.call_args[0][1] == table_name
assert cm_mock.call_args[0][2] == 'fail'
assert cm_mock.call_args[0][3] is True
assert norm_table_name == table_name


def test_to_carto_two_geom_columns_and_geom_col(mocker):
# Given
table_name = '__table_name__'
cm_mock = mocker.patch.object(ContextManager, 'copy_from')
cm_mock.return_value = table_name
df = GeoDataFrame({'geometry': [Point([0, 0])],
'the_geom': '010100000000000000000000000000000000000000'})

# When
norm_table_name = to_carto(df, table_name, CREDENTIALS, geom_col='geometry')

# Then
assert cm_mock.call_args[0][1] == table_name
assert cm_mock.call_args[0][2] == 'fail'
assert cm_mock.call_args[0][3] is True
assert norm_table_name == table_name


def test_to_carto_chunks(mocker):
# Given
table_name = '__table_name__'
Expand Down