josema/ch86072/improve-metrics-in-case-of-on-prem #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus89
requested changes
Sep 4, 2020
| json_data = build_metrics_data(event_name, extra_metrics_data) | ||
| result = requests.post('https://bmetrics.cartodb.net', json=json_data, timeout=2) | ||
| def post_metrics(event_name, extra_metrics_data, server_domain_tld): | ||
| metrics_server = STAG_METRICS_SERVER if server_domain_tld == STAG_DOMAIN_TLD else PROD_METRICS_SERVER |
There was a problem hiding this comment.
I would move this logic to utils.get_metrics_server(server_domain_tld) or get_metrics_server(server_domain_tld) (this file)
|
Re CR, please!! |
Jesus89
deleted the
josema/ch86072/improve-metrics-in-case-of-on-prem
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CH story ch86072