Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

josema/ch88278/provide_google_creds_in_cartoframes #1688

Merged
merged 6 commits into from
Oct 13, 2020
Merged

josema/ch88278/provide_google_creds_in_cartoframes #1688

merged 6 commits into from
Oct 13, 2020

Conversation

josemazo
Copy link
Contributor

@josemazo josemazo commented Sep 8, 2020

CH story: ch88278

@josemazo josemazo requested a review from Jesus89 September 8, 2020 07:39
antoniocarlon
antoniocarlon approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@antoniocarlon antoniocarlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@antoniocarlon antoniocarlon merged commit 523a9c2 into develop Oct 13, 2020
@antoniocarlon antoniocarlon deleted the josema/ch88278/provide-google-creds-in-cartoframes branch October 13, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniocarlon antoniocarlon antoniocarlon approved these changes

@Jesus89 Jesus89 Awaiting requested review from Jesus89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemazo @antoniocarlon