Fix empty popups #1689
Merged
Fix empty popups #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus89
approved these changes
Sep 15, 2020
| @@ -51,7 +51,7 @@ export function updatePopup(map, popup, event, attrs) { | |||
| .setLngLat([event.coordinates.lng, event.coordinates.lat]) | |||
| .setHTML(`<div class="popup-content">${popupHTML}</div>`); | |||
|
|
|||
| if (!popup.isOpen()) { | |||
| if (popupHTML.length > 0 && !popup.isOpen()) { | |||
There was a problem hiding this comment.
if (popupHTML should be enough. But it's OK.
antoniocarlon
deleted the
bug/ch100627/nikhita-stord-blank-popups-showing-for-a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a map with several layers CF allows us to define different behaviors for the popups of the different layer, but in the front-end the behavior of the popups is defined by map (instead of by layer).
This PR removes the popups from the entities that show empty ones. It's not the ideal fix but the perfect fix would force us to revisit the
MapandLayermodels (and maybe theFeatureone, not sure...).For now this PR should be harmless because it only removes completely empty popups (if the popup shows the name of the feld it won't be removed), and it works for both hover and click popups