Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize datasets/geographies download #1693

Merged

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Oct 5, 2020

A better and faster implementation to check the current user subscriptions.

It also uses the new status attribute. Already implemented and deployed in carto-python 1.11.2

@Jesus89 Jesus89 requested a review from antoniocarlon October 5, 2020 12:30
Copy link
Contributor

@antoniocarlon antoniocarlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment to avoid code duplication

cartoframes/data/observatory/catalog/dataset.py Outdated Show resolved Hide resolved
Copy link
Contributor

@antoniocarlon antoniocarlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Jesus89 Jesus89 merged commit eea7f9f into develop Oct 6, 2020
@Jesus89 Jesus89 deleted the bug/ch109174/reduce-unnecessary-requests-in-to-file-dataframe branch October 6, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants