Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate carto_geocode_hash with NULL values #1702

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Generate carto_geocode_hash with NULL values #1702

merged 2 commits into from
Nov 11, 2020

Conversation

Algunenano
Copy link
Contributor

Use concat instead of || to avoid generating NULL strings

References ch102254

@Algunenano
Generate carto_geocode_hash with NULL values
ffc4498 
Use concat instead of || to avoid generating NULL strings
Jesus89
Jesus89 approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Algunenano Algunenano merged commit c25dd0b into develop Nov 11, 2020
@Jesus89
Copy link
Member

Jesus89 commented Nov 11, 2020

BTW, in order to test this, it should be installed directly from the GH branch via pip.

@Algunenano Algunenano deleted the ch102254 branch November 23, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jesus89 Jesus89 Jesus89 approved these changes

@jgoizueta jgoizueta Awaiting requested review from jgoizueta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Algunenano @Jesus89