Avoid renaming geometry if geometry name is already GEOM_COLUMN_NAME #1726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In this small PR from Support we aim to fix an undesired behavior when using the
rename_geometry
method from theto_carto
function.Since the latest additions to GeoPandas, if the column name to be used as input for the referred function is already present in the GeoDataFrame columns, an error would be raised, which seems to break data uploads when the geometry column is named
the_geom
.Further details can be found in this CH story.
PR changes
io/carto.py: Avoid using the
rename_geometry
method if the GeoDataFrame's geometry column is named as GEOM_COLUMN_NAME (the_geom)Result with PR changes