Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows use of overwrite + privacy in write operations #349

Merged
merged 4 commits into from
Dec 15, 2017

Conversation

andy-esch
Copy link
Contributor

closes #252

@coveralls
Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage decreased (-0.5%) to 97.205% when pulling 8aa90ae on iss252-privacy-overwrite-bug into b24295e on master.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage decreased (-0.5%) to 97.205% when pulling 8aa90ae on iss252-privacy-overwrite-bug into b24295e on master.

@coveralls
Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage decreased (-0.2%) to 97.546% when pulling 222d4d5 on iss252-privacy-overwrite-bug into b24295e on master.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage decreased (-0.2%) to 97.546% when pulling 222d4d5 on iss252-privacy-overwrite-bug into b24295e on master.

@coveralls
Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage increased (+0.05%) to 97.751% when pulling 28dea8c on iss252-privacy-overwrite-bug into b24295e on master.

@andy-esch andy-esch merged commit d9515d5 into master Dec 15, 2017
@andy-esch andy-esch deleted the iss252-privacy-overwrite-bug branch December 15, 2017 19:56
@Eh2406
Copy link
Contributor

Eh2406 commented Dec 15, 2017

I doubt this closes #252. I think that reloading the web ui, will reset the table to private.

My current code uses an explicit

dataset = dataset_manager.get("table_name")
dataset.privacy = u'LINK'
dataset.save()

And still when the web ui is reloaded it is private.

If there is an easy way for me to install a version with this merged I will test.

@andy-esch
Copy link
Contributor Author

Ok, it's in the tests and seems to work as expected, but I'd love if you could verify.

You can install from master with this:

pip install git+https://github.com/cartodb/cartoframes.git#egg=cartoframes

@Eh2406
Copy link
Contributor

Eh2406 commented Dec 15, 2017

I am not surprised your test pass, I have always been able to set the privacy of the updated table. It just gets reset to private when the ui is reloaded.

I will test now.

@andy-esch
Copy link
Contributor Author

Good to know -- I'll look into that

@Eh2406
Copy link
Contributor

Eh2406 commented Dec 15, 2017

I stand corrected. The new code seems to be working! Thank you!

@andy-esch
Copy link
Contributor Author

Great!! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with overwrite and privacy flags set in cc.write, privacy is not updated
3 participants