Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moves table generation query to payload instead of param #375

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

andy-esch
Copy link
Contributor

@andy-esch andy-esch commented Feb 6, 2018

in CartoContext.query, you can create a new table on carto, but long queries like you'd have with data observatory augmentation were causing a 414 (too long URI). So the query should be moved to the body of the POST. That's what this handles.

closes #310, closes #335

@coveralls
Copy link

coveralls commented Feb 6, 2018

Coverage Status

Coverage decreased (-0.2%) to 97.561% when pulling fc64f6d on query-post-payload-and-errors into 6c1fddc on master.

@andy-esch andy-esch merged commit 777ff51 into master Feb 6, 2018
@andy-esch andy-esch deleted the query-post-payload-and-errors branch February 6, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create table with sql api first, then import api with tablename and sql params Error with persist_as
2 participants