Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes case where dataframe columns are a subset of util cols #523

Merged
merged 6 commits into from
Dec 18, 2018
Merged

fixes case where dataframe columns are a subset of util cols #523

merged 6 commits into from
Dec 18, 2018

Conversation

andy-esch
Copy link
Contributor

@andy-esch andy-esch commented Dec 14, 2018 •
edited
Loading

  • fixes case where columns are: 1. the_geom, 2. the_geom & cartodb_id
  • fixes case where column is only cartodb_id
    - [ ] fixes case where the only column is the_geom_webmercator not going to fix in this PR

Closes #384

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 97.708% when pulling 7faeb51 on iss384-util-col-dataframes-io into 8a4341a on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 97.708% when pulling 7faeb51 on iss384-util-col-dataframes-io into 8a4341a on master.

@coveralls
Copy link

coveralls commented Dec 14, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 97.708% when pulling d3205ce on iss384-util-col-dataframes-io into 8a4341a on master.

@andy-esch andy-esch changed the title fixes case where dataframe is subset of util cols fixes case where dataframe columns are a subset of util cols Dec 14, 2018
@andy-esch andy-esch merged commit 9672801 into master Dec 18, 2018
@andy-esch andy-esch deleted the iss384-util-col-dataframes-io branch December 18, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

don't try to update schema if only columns are cartodb_id / the_geom and/or the_geom_webmercator
2 participants
@andy-esch @coveralls