Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation typo #547

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Fix documentation typo #547

merged 1 commit into from
Feb 27, 2019

Conversation

rochoa
Copy link
Contributor

@rochoa rochoa commented Feb 27, 2019

@andy-esch, should we accept user and username for backwards compatibility?

@rochoa
Fix documentation typo
9089039 
@andy-esch, should we accept `user` and `username` for backwards compatibility?
@rochoa rochoa requested a review from andy-esch February 27, 2019 09:35
andy-esch
andy-esch approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@andy-esch andy-esch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@andy-esch andy-esch merged commit 1b5b9f1 into master Feb 27, 2019
@andy-esch andy-esch deleted the credentials-doc-typo branch February 27, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-esch andy-esch andy-esch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rochoa @andy-esch