648 default style #675
648 default style #675
Conversation
| return defaults._CREDENTIALS | ||
| return defaults.CREDENTIALS | ||
|
|
||
| def _get_geom_type(dataset): |
There was a problem hiding this comment.
Make hound happy again
There was a problem hiding this comment.
This commit should fix the linter: 862dd2a
|
|
||
| def _map_geom_type(self, geom_type): | ||
| return { | ||
| 'Point': Dataset.GEOM_TYPE_POINT, |
There was a problem hiding this comment.
Only a question: why don't we use the usual ones (without the _map_geom_type method)
- Point
- MultiPoint
- LineString
- MultiLineString
- Polygon
- MultiPolygon
There was a problem hiding this comment.
Because we need to group to point, line and polygon. Point and MultiPoint have the same style, LineString and MultiLineString have the same style, etc.
You can take a look at how default styles are defined: https://github.com/CartoDB/cartoframes/pull/675/files#diff-3233096e59fdf4159c753178da9e9c37R31.
There was a problem hiding this comment.
I can move this function to the Source class.
There was a problem hiding this comment.
Maybe we should use this dict closer to the visualization part, but I think is good enough right now.
| @@ -1,30 +1,21 @@ | |||
| _HTML_TEMPLATE = '<iframe srcdoc="{srcdoc}" width="{width}" height="{height}"></iframe>' | |||
| CARTO_VL_PATH = 'https://libs.cartocdn.com/carto-vl/v1.2.5/carto-vl.min.js' | |||
There was a problem hiding this comment.
IMO we should turn to just v1.2 for free updates from our cdn
Closes #648