Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

684 style defaults #685

Merged
merged 10 commits into from
May 23, 2019
Merged

684 style defaults #685

merged 10 commits into from
May 23, 2019

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented May 21, 2019

Related to #684.

  • Merge string / dict properties with default style properties
  • Add tests
  • Update examples

@Jesus89 Jesus89 requested a review from elenatorro May 21, 2019 16:10
'color': 'red',
'strokeWidth': 0
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

"""vis.Style.compute_viz should return the viz from a string with defaults"""
style = vis.Style('@var: 1\ncolor: red')
viz = style.compute_viz('line')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

@Jesus89 Jesus89 merged commit 2c8b8f5 into develop May 23, 2019
@andy-esch andy-esch deleted the 684-style-defaults branch July 16, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants