Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/unify dependencies (+update carto) #722

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Update/unify dependencies (+update carto) #722

merged 2 commits into from
Jun 3, 2019

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Jun 3, 2019 •
edited
Loading

This PR updates the dependencies in the setup.py file. The duplicated deps in requirements-docs have been removed, and the requirements.txt file now contains a . to load the deps from the setup.py.

In this PR we have updated the carto-python version to validate the rc1.

@Jesus89 Jesus89 requested review from alrocar and andy-esch June 3, 2019 13:57
@Jesus89 Jesus89 changed the title Update/unify dependencies Update/unify dependencies (+update carto) Jun 3, 2019
alrocar
alrocar approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@alrocar alrocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 didn't know the . trick in the requirements file

andy-esch
andy-esch approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@andy-esch andy-esch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! I didn't know the . trick either!

@Jesus89 Jesus89 merged commit 03401bd into develop Jun 3, 2019
@Jesus89 Jesus89 deleted the update-carto-python branch June 3, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-esch andy-esch andy-esch approved these changes

@alrocar alrocar alrocar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jesus89 @alrocar @andy-esch