Histogram / Category widget #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 28, 2019
|
I've also taken the chance to fix the always present legends panel, and given it a readable title. |
elenatorro
reviewed
Jul 1, 2019
| @@ -1,11 +1,11 @@ | |||
| {% include 'utils/format.js.j2' %} | |||
|
|
|||
| function renderWidget(layer, widget, variable, layerIndex, widgetIndex=0) { | |||
| const element = document.querySelector(`#layer${layerIndex}_widget${widgetIndex}-${widget.name}`); | |||
| const element = widget.element; | |||
elenatorro
reviewed
Jul 1, 2019
| } | ||
| else: | ||
| return {} | ||
|
|
||
| def has_variable(self): | ||
| return self._type == 'formula' |
elenatorro
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #811
Fix #810
Fix #771
I added some features to the widget class. We'll need some options to pass down to the bridge, and we might want to add some extra options for the components themselves.
For instance, the category widget should probably have some height limitations and a way to tweak max visible categories.