-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Map Grid to support multiple maps #892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 2, 2019
Suggestion: thinking about global settings, shared among different Maps:
|
I think that the work that has already been done is awesome, really. I wouldn't try to improve it now because it's already giving a lot of value. Here are my thoughts about each topic:
|
houndci-bot
reviewed
Aug 6, 2019
houndci-bot
reviewed
Aug 6, 2019
houndci-bot
reviewed
Aug 6, 2019
houndci-bot
reviewed
Aug 8, 2019
houndci-bot
reviewed
Aug 9, 2019
houndci-bot
reviewed
Aug 9, 2019
houndci-bot
reviewed
Aug 12, 2019
houndci-bot
reviewed
Aug 12, 2019
simon-contreras-deel
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do:
Image:
html2canvas
to display visualizations as an imageLegends:
[ ] Example using helper methods with default legends (and how to disable them when using the grid, for instance)next[ ] In MapGrid maps, we could add legends horizontally below / above the mapnextPublishing:
[ ] How an interactive MapGrid will be published?next[ ] Would be possible to publish a MapGrid image, so we can access it by URL?nextParameters:
[ ]It's displayed in the last mapshow_attribution
: to display / hide attribution informationviewport
: to set a common viewport to all the mapsbasemap
)Others