Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Map Grid to support multiple maps #892

Merged
merged 21 commits into from
Aug 12, 2019
Merged

Conversation

elenatorro
Copy link
Contributor

@elenatorro elenatorro commented Aug 2, 2019

To Do:

  • Image:

    • Use html2canvas to display visualizations as an image
  • Legends:

    • [ ] Example using helper methods with default legends (and how to disable them when using the grid, for instance) next
    • [ ] In MapGrid maps, we could add legends horizontally below / above the map next
  • Publishing:

    • [ ] How an interactive MapGrid will be published? next
    • [ ] Would be possible to publish a MapGrid image, so we can access it by URL? next
  • Parameters:

    • [ ] show_attribution: to display / hide attribution information It's displayed in the last map
    • viewport: to set a common viewport to all the maps
    • other parameters? (i.e.: basemap)
  • Others

    • Set attribution expanded by default, instead of showing a button.
    • Test many complex visualizations to check notebook performance issues

cartoframes/viz/html/utils.py Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
@VictorVelarde
Copy link
Contributor

Suggestion: thinking about global settings, shared among different Maps:

  • viewport
  • basemap
  • attribution

@cmongut
Copy link
Contributor

cmongut commented Aug 5, 2019

I think that the work that has already been done is awesome, really. I wouldn't try to improve it now because it's already giving a lot of value. Here are my thoughts about each topic:

  • Legends: don't worry about them right now. The customer shouldn't use helpers with grids but if they use them, we will improve it in the future.
  • Publishing: I wouldn't allow to publish a MapGrid for now. We will work on it if it makes sense in the future.
  • Parameters: I wouldn't allow them for now.
  • Expanded attribution by default: I think it makes sense.
  • Test performance: let's do one test to see what happens.

cartoframes/assets/src/utils.js Show resolved Hide resolved
cartoframes/assets/src/map.js Outdated Show resolved Hide resolved
cartoframes/assets/src/map.js Outdated Show resolved Hide resolved
cartoframes/assets/src/map.js Outdated Show resolved Hide resolved
cartoframes/assets/src/map.js Show resolved Hide resolved
cartoframes/assets/src/map.js Outdated Show resolved Hide resolved
cartoframes/assets/src/map.js Outdated Show resolved Hide resolved
cartoframes/assets/src/map.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/map.js Outdated Show resolved Hide resolved
cartoframes/assets/src/map.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/viz/mapgrid.py Outdated Show resolved Hide resolved
cartoframes/viz/mapgrid.py Outdated Show resolved Hide resolved
cartoframes/viz/mapgrid.py Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
@elenatorro elenatorro marked this pull request as ready for review August 9, 2019 13:16
@elenatorro elenatorro requested a review from andy-esch August 9, 2019 13:17
cartoframes/assets/src/utils.js Outdated Show resolved Hide resolved
cartoframes/assets/src/utils.js Outdated Show resolved Hide resolved
cartoframes/assets/src/utils.js Show resolved Hide resolved
cartoframes/assets/src/utils.js Show resolved Hide resolved
cartoframes/assets/src/map.js Outdated Show resolved Hide resolved
cartoframes/assets/src/layers.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Outdated Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
cartoframes/assets/src/bundle.js Show resolved Hide resolved
@elenatorro elenatorro requested a review from rjimenezda August 12, 2019 09:55
Copy link
Contributor

@simon-contreras-deel simon-contreras-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elenatorro elenatorro merged commit 96e2c8d into develop Aug 12, 2019
@elenatorro elenatorro deleted the feature/map-grid branch August 12, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants