Fix comma-separation of column in generated CREATE FOREIGN TABLE

CartoDB · Oct 21, 2020 · a8e9119 · a8e9119
1 parent 91af33a
commit a8e9119
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/odbc_fdw.c b/odbc_fdw.c
@@ -1950,6 +1950,7 @@ odbcImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)
 	SQLLEN indicator;
 	const char* schema_name;
 	bool missing_foreign_schema = false;
+	bool first_column = true;
 
 	elog_debug("%s", __func__);
 
@@ -2008,10 +2009,15 @@ odbcImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)
 				elog(NOTICE, "Data type not supported (%d) for column %s", DataType, ColumnName);
 				continue;
 			}
-			if (i > 1)
+			if (!first_column)
 			{
 				appendStringInfo(&col_str, ", ");
 			}
+			else
+			{
+				first_column = false;
+			}
+
 			appendStringInfo(&col_str, "\"%s\" %s", ColumnName, (char *) sql_type.data);
 		}
 		SQLCloseCursor(query_stmt);