Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map varchar(0) to text #125

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Map varchar(0) to text #125

merged 2 commits into from
Sep 29, 2020

Conversation

jgoizueta
Copy link

Fixes #59

Some text types are mapped by ODBC drivers to VARCHAR(0) which is not valid in Postgres. Now we map such cases to text.

@jgoizueta jgoizueta requested a review from rafatower September 17, 2020 09:08
rafatower
rafatower approved these changes Sep 17, 2020
View reviewed changes
Copy link

@rafatower rafatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jgoizueta jgoizueta merged commit cd92b83 into master Sep 29, 2020
@jgoizueta jgoizueta deleted the fix-varchar-0 branch September 29, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafatower rafatower rafatower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MS SQL column of type nvarchar(max) fails to import (maps to varchar(0))
2 participants
@jgoizueta @rafatower