fix: store raster nodata value in table metadata #111
Conversation
|
This pull request has been linked to Shortcut Story #307121: Handle nodata values in raster-loader. |
| @@ -585,6 +589,7 @@ def rasterio_windows_to_records( | |||
| if output_quadbin: | |||
| rec = array_to_quadbin_record( | |||
| raster_dataset.read(band, window=window), | |||
| raster_dataset.nodata, | |||
There was a problem hiding this comment.
if there is no "nodata" records in a raster what would happen?
The current solution only covers the first time a raster table it's uploaded. We can append tables, in that case to me it's ok taking any of both nodata fields the new one or the old one. If they are not the same the user will have problems though. Something similar happens with the field resolution
There was a problem hiding this comment.
If there aren't any nodata pixels, the nodata value can be defined anyway (in some file formats is mandatory to define it, in other it is not)
If it is not defined in the file, rasterio returns null, so the metadata would have null. We can decide if, in that case, we want to keep it like that, or maybe not add the "nodata" property to the metadata object
There was a problem hiding this comment.
that is what i was wondering if there are situations where we don't introduce the nodata. Then we should at least take care of it when appending tables. In the function write_metadata you will see that there are two cases, append_records or not, for now maybe you are testing by using --overwrite so the process is never appending data
There was a problem hiding this comment.
This topic as been discussed and nodata is introduced by row. So this implementation makes sense. It's not a global metadata field that we have to append.
Jesus89
deleted the
feature/sc-307121/handle-nodata-values-in-raster-loader
branch
Issue
Fixes #
https://app.shortcut.com/cartoteam/story/307121/handle-nodata-values-in-raster-loader
Proposed Changes
This PR adds the nodata value of the raster layer to the table metadata
Pull Request Checklist