Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a basic docker-compose based dev environment #80

Merged
merged 5 commits into from
Jan 21, 2023

Conversation

brendancol
Copy link
Contributor

@brendancol brendancol commented Jan 20, 2023

Issue

Related to #58

Proposed Changes

Add a docker-compose based docker development environment for raster_loader with associated commands in the Makefile.

This PR add the following new commands to the Makefile:

  • docker-build: Build necessary stuff.
  • docker-start: Start container with docker-compose and attach to logs.
  • docker-test: Enter the running raster_loader container and run tests.
  • docker-enter: Enter the raster_loader container.
  • docker-stop: Stop container

Pull Request Checklist

  • I have tested the changes locally
  • I have added tests to cover my changes (if applicable)
  • I have updated the documentation (if applicable)

Additional Information

I added the docker- prefix to these commands just to keep other existing commands intact, but moving forward we could switch all Makefile commands to interact with the Docker environment and drop the docker- prefix.

@brendancol brendancol added documentation Improvements or additions to documentation enhancement New feature or request infrastructure Related to infrastructure (GH, deployment, etc.) labels Jan 20, 2023
@brendancol brendancol self-assigned this Jan 20, 2023
@brendancol brendancol requested review from giancastro and removed request for francois-baptiste January 20, 2023 18:19
@tcmetzger tcmetzger linked an issue Jan 20, 2023 that may be closed by this pull request
@brendancol brendancol removed the request for review from giancastro January 21, 2023 09:55
@brendancol brendancol merged commit 40fd171 into main Jan 21, 2023
@Jesus89 Jesus89 deleted the docker-dev-environment branch April 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request infrastructure Related to infrastructure (GH, deployment, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use raster-loader with docker
1 participant