Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra script to create union between ground truth and prediction #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lrob
Copy link

@lrob lrob commented Mar 6, 2019

When you encounter file not found error, it's usually because you have
mismatched numbers of ground-truth and predicted files.
You can use this script to create missing files as empty file. The rationale
behind is the following:

  • if a file is missing from the ground truth but is present among the predictions it means that we have false positives
  • if a file is missing from the predictions but is present in the ground truth it means that we have a false negative

@Cartucho
Copy link
Owner

Cartucho commented Mar 9, 2019

Hello, this script is based on the following, right?

It would be easier if you applied the changes directly to that script.

@lrob
Copy link
Author

lrob commented Mar 9, 2019

Yes it is, but they are doing different things. one intersects the two sets of files and mine makes the union. I think it is better to keep them separated, are you of the same opinion?

@Cartucho
Copy link
Owner

Oh sorry, I only saw this now! So, by union you mean creating empty files when missing, right?

I think that is a great idea, better than deleting or moving files (what the intersection is doing right now)!

@lrob
Copy link
Author

lrob commented May 16, 2019

Yes, right. That's what I mean with union. If you think that it is better then the current solution probably it is the case to change also the comment written by the code when it detects that some prediction or gt files are missing. But I let you decide about this.

@Cartucho
Copy link
Owner

Yes, your solution is better, let's also change that comment.

Even better the code should do this automatically.
If the file is not found, it should show a warning and add the empty file automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants