fix: building to executable #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Have you reported the issue upstream? Please add a link to the relevant issue so we can follow it. |
|
Yes, there is already a rather old issue against pkg for this vercel/pkg#75 and I opened one against express-pouchdb yesterday pouchdb/pouchdb-server#326 |
|
Can you add the links to the README and then I'm happy to merge. Thanks! |
|
links added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #23
I have tried to keep this as minimal and lightweight as possible.
The json package has no dependencies, so should have minimal impact to dependency tree size. I did try with plain npm commands, but doing an uninstall installs everything else which felt too wasteful.
I have tested this on both windows and linux and it now builds a binary on both and I can still use the pouchdb endpoint