Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port 2.1 image scroll producer #1372

Merged
merged 4 commits into from
Mar 15, 2021
Merged

feat: port 2.1 image scroll producer #1372

merged 4 commits into from
Mar 15, 2021

Conversation

ronag
Copy link
Member

@ronag ronag commented Feb 21, 2021

No description provided.

@ronag ronag requested review from 5opr4ni and Julusian March 6, 2021 17:00
@ronag ronag marked this pull request as ready for review March 6, 2021 17:00
@ronag
Copy link
Member Author

ronag commented Mar 6, 2021

@5opr4ni this is ready for you to be verified

@5opr4ni
Copy link
Contributor

5opr4ni commented Mar 7, 2021

@5opr4ni this is ready for you to be verified

I’ll have a look. Was in transmission when I saw it, and almost missed putting on some graphics. 🤣 (Mello)

@dotarmin
Copy link
Contributor

dotarmin commented Mar 9, 2021

@ronag This is not building unfortunately on the build server. It complains about unresolved external symbols and the build fails with two errors of the same type (see below).

error LNK2019: unresolved external symbol

Other branches works as expected.

Let me know what more information you need

@ronag
Copy link
Member Author

ronag commented Mar 9, 2021

Probably missing a reference to the cpp file in some make file.

@dotarmin
Copy link
Contributor

dotarmin commented Mar 9, 2021

Probably missing a reference to the cpp file in some make file.

Roger that. Let me know when you have looked at it so I can run the build.

@5opr4ni
Copy link
Contributor

5opr4ni commented Mar 10, 2021

All expected commands works as expected regarding to function but not time.
Duration and end_time are probably based on another time. (A DURATION of 20 took 40 seconds.)
These commands where tested:
PLAY 1-10 mellocred speed 8

PLAY 1-10 mellocred speed 4 BLUR 4

PLAY 1-10 mellocred speed 8 BLUR 10

PLAY 1-10 hscrolltest speed 8 BLUR 10

PLAY 1-10 mellocred DURATION 20 BLUR 4

PLAY 1-10 mellocred END_TIME "2021-03-10 14:45:17"

Copy link
Contributor

@5opr4ni 5opr4ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All expected commands works as expected regarding to function but not time.
Duration and end_time are probably based on another time. (A DURATION of 20 took 40 seconds.)

@ronag ronag force-pushed the image-scroll-producer branch from 4fcf131 to fbd55c2 Compare March 11, 2021 16:52
@5opr4ni
Copy link
Contributor

5opr4ni commented Mar 15, 2021

Tested hard during rehearsals and broadcast of Melodifestivalen. Worked flawlessly! 🥳

@ronag ronag merged commit 4de6d18 into master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants