-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port 2.1 image scroll producer #1372
Conversation
@5opr4ni this is ready for you to be verified |
I’ll have a look. Was in transmission when I saw it, and almost missed putting on some graphics. 🤣 (Mello) |
@ronag This is not building unfortunately on the build server. It complains about unresolved external symbols and the build fails with two errors of the same type (see below).
Other branches works as expected. Let me know what more information you need |
Probably missing a reference to the cpp file in some make file. |
Roger that. Let me know when you have looked at it so I can run the build. |
All expected commands works as expected regarding to function but not time. PLAY 1-10 mellocred speed 4 BLUR 4 PLAY 1-10 mellocred speed 8 BLUR 10 PLAY 1-10 hscrolltest speed 8 BLUR 10 PLAY 1-10 mellocred DURATION 20 BLUR 4 PLAY 1-10 mellocred END_TIME "2021-03-10 14:45:17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All expected commands works as expected regarding to function but not time.
Duration and end_time are probably based on another time. (A DURATION of 20 took 40 seconds.)
4fcf131
to
fbd55c2
Compare
Tested hard during rehearsals and broadcast of Melodifestivalen. Worked flawlessly! 🥳 |
No description provided.