Feature: Show current episode in season list and mark current episode in episode list #1667
Conversation
| if 'current' in source: | ||
| path = reference_path(source['current']) | ||
| if path is not None: | ||
| yield ('current', path) |
There was a problem hiding this comment.
Added current to iterate_references
| @@ -255,6 +255,8 @@ def __init__(self, videoid, path_response): | |||
| self.tvshow = self.data['videos'][self.videoid.tvshowid] | |||
| self.seasons = OrderedDict( | |||
| resolve_refs(self.tvshow['seasonList'], self.data)) | |||
| if 'current' in self.tvshow['seasonList']: | |||
| self.current_seasonid = videoid.derive_season(self.tvshow['seasonList']['current']['value'][1]) | |||
There was a problem hiding this comment.
Is getting the value like self.tvshow['seasonList']['current']['value'][1] ok?
"seasonList": {
"current": {
"$type": "ref",
"value": [
"seasons",
"81370447"
]
}
}
|
I had thought about this in the past and intentionally avoided doing anything like this, 1° big problem: 2° big problem: in the past i have tried also an alternative way by using the metadata api to do something like this, but its the same problem no fresh data and the problem 2 is still here 3°: these problems will not make this feature so reliable other side notes despite all:
|
|
Thank you for taking the time to answer. I understand that this will add some complexity but I really miss this feature. Add added my thoughts:
Yes this could be a problem, but is it not the same with all the other api paths? All the paths are hard coded and only the video_id / list_id are changed for the request. 1° problem:
Okay I understand that refreshing the GUI with the new episode can be a problem. A (not perfect) solution could be that we remove the current episode data after starting the video. If we are to late with loading the current episode, because of asynchronous, nothing will be shown and if we get the current data fast enough, it will be displayed correctly.
For my tests i never had a problem with pathEvaluator but I understand that it could me a problem over time. Could it work if we are only showing and requesting the current episode for the "Continue Watching" list? Each tv show which is in the continue watching list will be updated. 2° problem:
But this will be the same problem on the official netflix website. It shows the same video on the netflix website and on kodi (watched but maybe not completed), so we can argue that this are the provided data from netflix and the same behavior.
Currently the user always don't know in which season and at which episode he is. So it will be still better to see the watched episode with the season / episode number in the title then having no information. And after starting a new episode it will work again. 3° problem:
Okay I didn't know that. Is synchronization state detectable? If yes, we could hide the current episode if synchronization is not working.
Yes this is much better. But then it is not possible to disable it.
Yes that was my thought too, but I added it because it is much more helpful to have the season and episode if something is wrong or the episode is already watched, then if you need to start searching in which season the next episode will be.
Thank you for the response. My first goal was to understand the code better and I will use the feature anyway for my self, so it not a problem if it will be not merged. But maybe with some modifications it will work for the offical addon too 😄 |
to get a list data you can re-adapt the code if changed, here you strictly depend on "current" value of seasonList,
There is the addon setting to enable/disable the watched status sync with website I'm blocking the PR for now, not closing it because when i will have time i want to understand and test better |
Check if this PR fulfills these requirements:
Types of changes
Description
Motivation: It would be very nice if it would be possible to resume the current episode or start the next episode of a tv show from the start screen / tv show overview. Like on the Netflix website. Currently I always need to remember at which season I'm and then I need to scroll down to select the episode after the last watched one.
In case of Feature change / Breaking change:
Describe the current behavior
Describe the new behavior
Screenshots (if appropriate):
Current episode in season list:
Colorized title of the current episode:
Settings:
Netflix:
Open tasks:
@CastagnaIT I need some help with the following points and the commented code sections:
4x08.is that ok?en_gbtranslation. Is that ok or does every translation file need the new entries?__init__ofSeasonListI added new lines. But I don't know if there is a cleaner way.req_current_episode. I'm not sure if this is needed