Support obfuscating cstr literals #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulDance
reviewed
May 14, 2024
Comment on lines
+203
to
+206
| pub const fn unsafe_as_str(bytes: &[u8]) -> &str { | ||
| // When used correctly by this crate's macros this should be safe | ||
| #[cfg(debug_assertions)] | ||
| return str::from_utf8(bytes).unwrap(); | ||
| return match str::from_utf8(bytes) { Ok(s) => s, Err(_) => panic!("invalid str") }; |
There was a problem hiding this comment.
Just passing by, even if this is only internal: the const part should not be required in both cases anymore, right?
|
Any chance to merge and release this some time soon? |
|
I haven't been very active sorry, I'll finish it this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.