Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
CasualYT31 authored Jul 14, 2021
1 parent 46cf88f commit f4f7f1d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ target_link_libraries(YourTargetNameHere SystemProperties)
Alternatively, you can simply download the code manually and add both `SystemProperties.hpp` and `SystemProperties.cpp` to your project directly as accompanying source files in case you don't wish to use CMake.

# Note on Performance
I intend to use command-line tools in order to carry out reliable queries. This may have an impact on the efficiency of the library, but it should make it robust and extensible. I have employed caching techniques in order to mitigate against the performance impact of relying on command-line utilities, however, if a faster way of performing the queries is identified in the future it will certainly be favoured.
I intend to use command-line tools in order to carry out "reliable" queries for now. This may have an impact on the efficiency of the library, but it should make it robust and extensible. I have employed caching techniques in order to mitigate against the performance impact of relying on command-line utilities, however, if a faster way of performing the queries is identified in the future it will certainly be favoured.

For Windows: so far I have used `Get-CimInstance` via PowerShell to perform *blocking* queries, and I have used temporary text files to output results. Temporary files are given the name "ClassNameObjectName.temp", e.g. "Win32_VideoControllerdriverversion.temp" for the `sys::gpu::driver()` call, and are stored in the current working directory. These files are removed once the query has been completed. These two details make this library pretty slow... However, as previously stated, results are cached, so that subsequent calls do not make PowerShell queries if they returned something other than a blank string when first called.

**Important: I have not made any checks to see if files already exist with the names given to the temporary files.**

# Progress
This library can currently obtain all information that [this library](https://github.com/dabbertorres/systemInfo) can, but for **Windows only**. I can very easily extend Windows-based features, but as I don't have access to a macOS device or easy access to a Linux device, no code has been written for other platforms yet.
This library can currently obtain all information that [this library](https://github.com/dabbertorres/systemInfo) can, plus some storage information, but for **Windows only**. I can very easily extend Windows-based features, but as I don't have access to a macOS device or easy access to a Linux device, no code has been written for other platforms yet.

0 comments on commit f4f7f1d

Please sign in to comment.