Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced workflow permissions #1793

Merged
merged 1 commit into from
Mar 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 6 additions & 25 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ on:
branches: [main]
pull_request:
branches: [main, '[0-9]+-[0-9]+-*']
workflow_run:
workflows: ['Build for Dependabot']
types:
- completed
workflow_dispatch:
workflow_call:
inputs:
Expand All @@ -20,37 +16,22 @@ on:
jobs:
build:
name: Build
if: |-
${{
!startsWith(github.head_ref, 'workflows/tests/') && ((
github.actor == 'dependabot[bot]' &&
github.event_name != 'push' &&
github.event_name != 'pull_request'
) || (
github.actor != 'dependabot[bot]' &&
github.event_name != 'workflow_run'
))
}}
runs-on: ubuntu-latest
permissions: write-all
permissions:
pull-requests: write
contents: write
steps:
- uses: actions/checkout@v3
if: ${{ github.event_name != 'workflow_run' }}
with:
ref: ${{ inputs.ref || github.head_ref || github.base_ref }}

- uses: actions/checkout@v3
if: ${{ github.event_name == 'workflow_run' }}
with:
ref: ${{ github.event.workflow_run.head_branch }}
ref: ${{ inputs.ref }}

- uses: actions/setup-node@v3
with:
node-version-file: '.nvmrc'
check-latest: true

- name: Install dependencies
run: yarn install
run: yarn

- name: Build
run: yarn build
Expand All @@ -61,6 +42,6 @@ jobs:
- uses: CatChen/check-git-status-action@v1
id: check-git-status
with:
fail-if-not-clean: ${{ github.actor != 'dependabot[bot]' || github.event_name == 'workflow_call' }}
fail-if-not-clean: ${{ github.actor != 'dependabot[bot]' }}
push-if-not-clean: true
github-token: ${{ secrets.CHECK_GIT_STATUS_ACTION_TOKEN }}
13 changes: 10 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,23 @@ on:
jobs:
build:
uses: ./.github/workflows/build.yml
secrets: inherit
permissions:
pull-requests: write
contents: write

test:
uses: ./.github/workflows/test.yml
secrets: inherit
permissions: write-all

eslint:
uses: ./.github/workflows/eslint.yml

codeql:
uses: ./.github/workflows/codeql.yml
permissions:
actions: read
contents: read
security-events: write

release:
name: Release
Expand All @@ -72,10 +78,11 @@ jobs:
uses: CatChen/node-package-release-action@v1
with:
release-type: ${{ inputs.release-type || 'patch' }}
prerelease: ${{ inputs.prerelease || true }}
prerelease: ${{ inputs.prerelease || false }}
update-shorthand-release: true
dry-run: ${{ inputs.dry-run || false }}
skip-if-no-diff: ${{ inputs.skip-if-no-diff || true }}
diff-targets: ${{ inputs.diff-targets || 'dist/**/*' }}

publish:
name: Publish
Expand Down
21 changes: 15 additions & 6 deletions .github/workflows/ship.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,15 @@ jobs:
contains(github.event.workflow_run.pull_requests.*.base.ref, 'main')
}}
runs-on: ubuntu-latest
permissions: write-all
permissions:
pull-requests: write
contents: write
outputs:
skipped: ${{ steps.ship.outputs.skipped }}
steps:
- uses: actions/checkout@v3

- id: ship
uses: ./
- uses: CatChen/accept-to-ship-action@v0.4
with:
merge-method: squash
timeout: 0
Expand All @@ -89,7 +90,9 @@ jobs:
contains(github.event.workflow_run.pull_requests.*.base.ref, 'main')
}}
runs-on: ubuntu-latest
permissions: write-all
permissions:
pull-requests: write
contents: write
outputs:
skipped: ${{ steps.ship.outputs.skipped }}
steps:
Expand All @@ -106,16 +109,18 @@ jobs:
build:
needs: [accept-to-ship, pass-to-ship]
if: ${{ !needs.accept-to-ship.outputs.skipped || !needs.pass-to-ship.outputs.skipped }}
permissions:
pull-requests: write
contents: write
uses: ./.github/workflows/build.yml
secrets: inherit
with:
ref: 'refs/heads/main'

test:
needs: [accept-to-ship, pass-to-ship]
if: ${{ !needs.accept-to-ship.outputs.skipped || !needs.pass-to-ship.outputs.skipped }}
permissions: write-all
uses: ./.github/workflows/test.yml
secrets: inherit
with:
ref: 'refs/heads/main'

Expand All @@ -129,6 +134,10 @@ jobs:
codeql:
needs: [accept-to-ship, pass-to-ship]
if: ${{ !needs.accept-to-ship.outputs.skipped || !needs.pass-to-ship.outputs.skipped }}
permissions:
actions: read
contents: read
security-events: write
uses: ./.github/workflows/codeql.yml
with:
ref: 'refs/heads/main'