Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing env vars in some test workflow steps #4878

Conversation

CatChen
Copy link
Owner

@CatChen CatChen commented Oct 23, 2024

No description provided.

@CatChen CatChen self-assigned this Oct 23, 2024
Copy link
Owner Author

CatChen commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on Graphite Graphite

Copy link

what-the-diff bot commented Oct 23, 2024

PR Summary

  • Changed Environment Variable in Workflow Step
    The environment variable labeled 'SHA' has been replaced with 'TEST_HEAD_PR_NUMBER' in a specific procedure of our work process that examines the condition of the test head pull request. This will improve the consistency and precision of our testing framework.

  • Introduction of New Environment Variable
    We've incorporated a new environment variable called 'TEST_BASE_PR_NUMBER' into another part of the workflow that closes down the base pull request. This change will enhance the way we identify and handle pull requests, making the entire system more robust and reliable.

  • Removed Redundant Code
    We have tidied up our code by getting rid of the part that sets the 'TEST_BASE_BRANCH_NAME' environment variable. This eliminates unnecessary complications and makes our software more efficient and straightforward to manage.

Copy link
Contributor

Checks from Test PR #4880

Check Status Time
security/gitguardian 0
Test in Pull Request 1m1s
GitGuardian Security Checks 3s

Copy link
Contributor

Checks from Test PR #4882

Check Status Time
security/gitguardian 0
Test in Pull Request 1m6s
GitGuardian Security Checks 1s

@accept-to-ship-bot accept-to-ship-bot bot merged commit 93ab639 into main Oct 23, 2024
14 checks passed
@accept-to-ship-bot
Copy link

This Pull Request is closed by a GitHub Action

@accept-to-ship-bot accept-to-ship-bot bot deleted the 10-23-fixed_missing_env_vars_in_some_test_workflow_steps branch October 23, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant