Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed storage stream. #228

Merged
merged 1 commit into from
May 18, 2019
Merged

Removed storage stream. #228

merged 1 commit into from
May 18, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed Yes
Tests pass? Yes
Doc pr? No

This submission removes Storage from the core library because it is used too frequently.

@ymh199478 ymh199478 mentioned this pull request May 18, 2019
55 tasks
@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

Merging #228 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   96.04%   96.01%   -0.03%     
==========================================
  Files          33       31       -2     
  Lines        2857     2660     -197     
==========================================
- Hits         2744     2554     -190     
+ Misses        113      106       -7
Impacted Files Coverage Δ
...c/CatLib.Core/Support/Extension/StreamExtension.cs 89.18% <0%> (-2.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c438840...22e1993. Read the comment docs.

@ymh199478 ymh199478 merged commit cb3cb03 into master May 18, 2019
@ymh199478 ymh199478 deleted the removed/free-storage branch May 18, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants