Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arr.cs optimization variable naming and guarding #263

Merged
merged 1 commit into from
Jul 27, 2019
Merged

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed No
Tests pass? Yes
Doc pr? No

This submission optimizes the variable naming and guarding of Arr.cs

@ymh199478 ymh199478 changed the title Arr.cs optimization. Arr.cs optimization variable naming and guarding Jul 27, 2019
@ymh199478 ymh199478 mentioned this pull request Jul 27, 2019
55 tasks
@codecov-io
Copy link

codecov-io commented Jul 27, 2019

Codecov Report

Merging #263 into master will decrease coverage by 0.48%.
The diff coverage is 92.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   90.13%   89.65%   -0.49%     
==========================================
  Files          36       36              
  Lines        2403     2407       +4     
==========================================
- Hits         2166     2158       -8     
- Misses        237      249      +12
Impacted Files Coverage Δ
src/CatLib.Core/Support/Arr.cs 92.59% <92.02%> (-4.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbdbfd6...62d41e6. Read the comment docs.

@ymh199478 ymh199478 merged commit 4f6810b into master Jul 27, 2019
@ymh199478 ymh199478 deleted the changed/free-arr branch July 27, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants