Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Str.cs optimization variable naming and guarding #264

Merged
merged 3 commits into from
Jul 27, 2019
Merged

Str.cs optimization variable naming and guarding #264

merged 3 commits into from
Jul 27, 2019

Conversation

ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed No
Tests pass? Yes
Doc pr? No

This submission optimizes the variable naming and guarding of Str.cs

@ymh199478 ymh199478 mentioned this pull request Jul 27, 2019
Closed
55 tasks
@ymh199478 ymh199478 merged commit 228ebb6 into master Jul 27, 2019
@ymh199478 ymh199478 deleted the changed/free-str branch July 27, 2019 06:36
@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

16 similar comments
@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jul 27, 2019 •
edited
Loading

Codecov Report

Merging #264 into master will decrease coverage by 0.27%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   89.65%   89.37%   -0.28%     
==========================================
  Files          36       36              
  Lines        2407     2410       +3     
==========================================
- Hits         2158     2154       -4     
- Misses        249      256       +7
Impacted Files Coverage Δ
src/CatLib.Core/Support/Str.cs 96.79% <93.68%> (-3.21%) ⬇️
src/CatLib.Core/Support/Arr.cs 92.18% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6810b...9d64bb4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ymh199478 @codecov-io