Skip to content
This repository has been archived by the owner on Apr 13, 2020. It is now read-only.

[FEATURE] have error code and chaining for deployment validate cmd #490

Merged
merged 5 commits into from
Apr 1, 2020

Conversation

dennisseah
Copy link
Collaborator

closes microsoft/bedrock#1291

also fix typos
rename validation.md => validate.md and validation.decorator.json => validate.decorator.json because they are named incorrectly

@samiyaakhtar samiyaakhtar removed the request for review from anderm April 1, 2020 20:55
@samiyaakhtar
Copy link
Collaborator

Would be nice to run the integration test for this logic (for changes in spk deployment create command)

@dennisseah
Copy link
Collaborator Author

Would be nice to run the integration test for this logic (for changes in spk deployment create command)

which integration test has this command, I did a grep and cannot find it. thanks

@samiyaakhtar
Copy link
Collaborator

The integration tests create pipelines which use this command, so it's not directly called from the integration test files. I think you can merge and if something breaks, we will see. :)

@dennisseah dennisseah merged commit 8f45e74 into master Apr 1, 2020
@dennisseah dennisseah deleted the issue1291 branch April 6, 2020 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have specific error codes and error chain for deployment validate command
3 participants