Skip to content
This repository has been archived by the owner on Apr 13, 2020. It is now read-only.

[HOUSEKEEPING] some fixes on service get service name command #536

Merged
merged 3 commits into from
Apr 9, 2020
Merged

[HOUSEKEEPING] some fixes on service get service name command #536

merged 3 commits into from
Apr 9, 2020

Conversation

dennisseah
Copy link
Collaborator

A few things that I have missing during the review

  1. align the error i18n keys with the other commands
  2. break negative tests into different tests and call out what the test is about
  3. added missing await in test

@dennisseah dennisseah merged commit 8d8852d into master Apr 9, 2020
@dennisseah dennisseah deleted the fixGetServiceNameCmd branch April 9, 2020 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrebriggs andrebriggs andrebriggs approved these changes

@mtarng mtarng mtarng approved these changes

@samiyaakhtar samiyaakhtar Awaiting requested review from samiyaakhtar

@bnookala bnookala Awaiting requested review from bnookala

@evanlouie evanlouie Awaiting requested review from evanlouie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dennisseah @andrebriggs @mtarng