CATROID-1417 Bug fixed where visual placement is skipped

Catrobat · Jul 5, 2022 · b06f6a3 · b06f6a3
1 parent 24737be
commit b06f6a3
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/catroid/src/main/java/org/catrobat/catroid/visualplacement/VisualPlacementActivity.java b/catroid/src/main/java/org/catrobat/catroid/visualplacement/VisualPlacementActivity.java
@@ -37,6 +37,7 @@
 import android.graphics.drawable.BitmapDrawable;
 import android.graphics.drawable.Drawable;
 import android.os.Bundle;
+import android.util.DisplayMetrics;
 import android.view.Gravity;
 import android.view.Menu;
 import android.view.MenuItem;
@@ -149,7 +150,11 @@ public boolean onOptionsItemSelected(MenuItem item) {
 
 	@Override
 	protected void onCreate(@Nullable Bundle savedInstanceState) {
-		super.onCreate(savedInstanceState);
+		super.onCreate(null);
+		DisplayMetrics displayMetrics = new DisplayMetrics();
+		getWindowManager().getDefaultDisplay().getMetrics(displayMetrics);
+		int height = displayMetrics.heightPixels;
+		int width = displayMetrics.widthPixels;
 
 		if (isFinishing()) {
 			return;
@@ -189,13 +194,14 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
 
 		frameLayout = findViewById(R.id.frame_container);
 
-		int screenWidth = ScreenValues.SCREEN_WIDTH;
-		int screenHeight = ScreenValues.SCREEN_HEIGHT;
+		int screenWidth = width;
+		int screenHeight = height;
 		int virtualScreenWidth = currentProject.getXmlHeader().virtualScreenWidth;
 		int virtualScreenHeight = currentProject.getXmlHeader().virtualScreenHeight;
 
 		float aspectRatio = (float) virtualScreenWidth / (float) virtualScreenHeight;
-		float screenAspectRatio = ScreenValues.getAspectRatio();
+		float screenAspectRatio = (float) width / (float) height;
+		// .getAspectRatio();
 
 		float scale;
 		float ratioHeight = (float) screenHeight / (float) virtualScreenHeight;