CATROID-449 move end2end tests against share to nightly runs #3451
Conversation
|
@jampo can you please review? if this is fine for you, can we move this job over to the jenkins root (out of my lab package). and is there any possibility to have test results posted to specific slack channels? (eg. catrobat share and scratch converter) thank you! |
There was a problem hiding this comment.
As discussed with @84n4n4 LGTM 👍
Maybe @jampo or @AndreasFinsterbusch can have a look at the jenkins file?
There was a problem hiding this comment.
The rest is fine for me +1
and is there any possibility to have test results posted to specific slack channels? (eg. catrobat share and scratch converter)
yes, you can report the build result to a channel. just add:
notifyChat(['#channelName1', '#ChannelName2']) into the post{always{}} block
Jenkinsfile.NightlyNetworkTests
Outdated
| stages { | ||
| stage('End to end tests requiring share authentication') { | ||
| steps { | ||
| catchError(buildResult: 'FAILURE' ,stageResult: 'FAILURE') { |
There was a problem hiding this comment.
this catchError block is unnecessary and should be removed!
|
changes suggested by @AndreasFinsterbusch applied, please recheck! thank you! |
There was a problem hiding this comment.
Following https://www.selfelected.com/code-reviewing-comments/ =>
PRAISE: This is great!!
CHECK: @84n4n4 will you still integrate the feedback from @AndreasFinsterbusch ?
FIX: These tests shall not have the word "nightly" anywhere in their name. These tests may have to be executed nightly alright, but they will also have to be executed at other times and on other occasions. Please rename Jenkisfile.NightlyNetworkTests to Jenkisfile.OutgoingNetworkCallTests or even better, Jenkisfile.SystemTests or something else that is fitting --- I'm not sure what the best name here would be. We already have other tests that should be kept separate from the tests for developers, though they are currently still included, e.g., the sensor box tests, or soon the robot arm tests etc. If so, will these be handled by the same Jenkisfile test suite? If yes, I would suggest to rename it already now to something like Jenkisfile.SystemTests --- but I'm willing to go for Jenkisfile.OutgoingNetworkCallTests if that will not be the case of course. Please let me know. Anyway, the "nightly" should be eliminated.
PRAISE: Now it is fine for me! |
|
@AndreasFinsterbusch is there any possibility to send notifications only when the tests fail? (and do nothing if the run is a success) notifyChat now commented out for the time. |
yes, currently it runs in the always section, |
|
@AndreasFinsterbusch kannst du bitte hier mal drüberschaun: hast du eine ahnung warum der job das git repo nicht mehr pullen kann? danke! |
Sollte wieder gehen, es wurde ein lock im Workspace nicht mehr freigeben. Weiß leider nicht wie es zu diesem fehler gekommen ist. Hoffe es tritt nicht mehr auf. Mir ist aufgefallen ihr habt paar deprecated warnings im log zb:
|
@84n4n4 Thomas will you fix these? Please tell me via slack when I can merge the PR. LGTM, but I'm not sure about the deprecation warnings, please decide and let me know. |
|
die deprecation warnings kommen seit dem dependency injection PR, da wurde "getInstance" als deprecated annotiert um zu verhindern dasses weiter in neuem code eingebaut wird. dabei wurden natürlich noch nicht alle occurrences eliminiert (da projectManager ja wirklich überall in der codebase angegriffen wird). hat also nichts mit diesem PR zu tun, und sollte eigentlich in allen anderen suits auch reported werden (abhängig vom eingestellten warning level) |
|
Thanks!! |
CATROID-449 move end2end tests against share to nightly runs
No description provided.