Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty formulas are now correctly displayed, if the ShowVariable brick is used #3455

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

trummerp
Copy link
Contributor

@trummerp trummerp commented Feb 5, 2020

With this update the ShowVariable brick are now correctly displaying empty variables/formulas as such instead of the predefined text "No value set".

Examples:
The formula "5" still results in "5".
The formula "" now results in "", instead of "No value set".

DinosaurierRex
DinosaurierRex previously approved these changes Feb 6, 2020
Copy link
Contributor

@DinosaurierRex DinosaurierRex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Static Analysis

@DinosaurierRex DinosaurierRex dismissed their stale review February 6, 2020 11:34

Static Analysis

Copy link
Contributor

@DinosaurierRex DinosaurierRex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslany wslany merged commit 651fa10 into Catrobat:develop Feb 7, 2020
@wslany
Copy link
Member

wslany commented Feb 7, 2020

Thanks!!

Koell pushed a commit to Koell/Catroid that referenced this pull request Feb 28, 2020
Empty formulas are now correctly displayed, if the ShowVariable brick is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants