CATROID-374 Implement sharing WebView Login automatically #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gPathpp
approved these changes
Feb 19, 2020
| @@ -249,6 +255,29 @@ private String getExtensionFromContentDisposition(String contentDisposition) { | |||
| return extension; | |||
| } | |||
|
|
|||
| public void setLoginCookies(String url) { | |||
| SharedPreferences sharedPreferences = | |||
| PreferenceManager.getDefaultSharedPreferences(getApplicationContext()); | |||
There was a problem hiding this comment.
If you declare sharedPreferences and cookieManager as a parameter, you'll be able to test the method. (Hint: mock it)
| Cookie tokenCookie = new Cookie(Cookie.TOKEN_COOKIE, token); | ||
| CookieManager.getInstance().setCookie(url, usernameCookie.generateCookieString()); | ||
| CookieManager.getInstance().setCookie(url, tokenCookie.generateCookieString()); | ||
| } |
|
Thanks! |
Koell
pushed a commit
to Koell/Catroid
that referenced
this pull request
Feb 28, 2020
CATROID-374 Implement sharing WebView Login automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.