Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-509 Upload of someone else´s project without any changes is n… #4021

Merged
merged 1 commit into from
Apr 20, 2021
Merged

CATROID-509 Upload of someone else´s project without any changes is n… #4021

merged 1 commit into from
Apr 20, 2021

Conversation

Walcho1125
Copy link
Contributor

@Walcho1125 Walcho1125 commented Mar 16, 2021 •
edited
Loading

…o longer possible

Upload of someone else's project without any changes shall not be possible!
https://jira.catrob.at/browse/CATROID-509

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@Walcho1125 Walcho1125 force-pushed the CATROID-509 branch 9 times, most recently from 273d95d to 7ebd8d6 Compare March 23, 2021 08:26
dandrawes
dandrawes requested changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@dandrawes dandrawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Please fix the small issues as discussed in the pair review.

@Walcho1125 Walcho1125 force-pushed the CATROID-509 branch 15 times, most recently from b2be365 to 33051f6 Compare March 31, 2021 12:21
@Walcho1125 Walcho1125 force-pushed the CATROID-509 branch 3 times, most recently from b9e64ad to 3ddcb7d Compare April 3, 2021 10:30
dandrawes
dandrawes approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@dandrawes dandrawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now!

@wslany wslany merged commit 02051e9 into Catrobat:develop Apr 20, 2021
@wslany
Copy link
Member

wslany commented Apr 20, 2021

Thanks!

@Walcho1125 Walcho1125 deleted the CATROID-509 branch April 21, 2021 11:55
@Walcho1125 Walcho1125 restored the CATROID-509 branch April 21, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandrawes dandrawes dandrawes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Walcho1125 @wslany @dandrawes