Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-921 Disable Hints dialog #4083

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Conversation

Veve8010
Copy link
Contributor

@Veve8010 Veve8010 commented Apr 6, 2021

Implement a dialog that asks the user if they want to enable or disable hints. The dialog is shown only once, right before the first hint would be shown and will not be shown again if the user changes the hint settings afterwards.
https://jira.catrob.at/browse/CATROID-921

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@Veve8010 Veve8010 force-pushed the CATROID-921 branch 14 times, most recently from 9913062 to 6d93d80 Compare April 13, 2021 12:19
@Veve8010
Copy link
Contributor Author

3 failing tests on jenkins (only "testEmptyTrustList.kt" fails also locally)

@Veve8010 Veve8010 force-pushed the CATROID-921 branch 4 times, most recently from 2c1385c to 1f64e50 Compare April 14, 2021 14:00
@wslany wslany merged commit b0cf7eb into Catrobat:develop Apr 21, 2021
@wslany
Copy link
Member

wslany commented Apr 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants