Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1168 Refactor UserDefinedBrickListFragment and PrototypeBrickAdapter to kotlin #4279

Merged
merged 1 commit into from
Jul 20, 2022
Merged

CATROID-1168 Refactor UserDefinedBrickListFragment and PrototypeBrickAdapter to kotlin #4279

merged 1 commit into from
Jul 20, 2022

Conversation

khushal1707
Copy link
Member

@khushal1707 khushal1707 commented Jul 26, 2021 •
edited
Loading

Ticket: https://jira.catrob.at/browse/CATROID-1168
Refactored UserDefinedBrickListFragment, PrototypeBrickAdapter to kotlin and added viewBinding to UserDefinedBrickListFragment

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@khushal1707 khushal1707 force-pushed the CATROID-1168 branch 2 times, most recently from c9df5c0 to 05122be Compare August 2, 2021 09:26
Walcho1125
Walcho1125 approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

ndrnour
ndrnour previously requested changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@ndrnour ndrnour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider my suggestions in your code.

@khushal1707
Copy link
Member Author

Done!!

@ndrnour
Copy link
Contributor

ndrnour commented Sep 2, 2021 •
edited
Loading

please fix the merge conflict.

@wslany
Copy link
Member

wslany commented Nov 14, 2021

@khushal1707 please could you fix the conflict and let us know.

@wslany
Copy link
Member

wslany commented Nov 14, 2021

Also, please squash the commits into one.

@juliajulie95 juliajulie95 removed the request for review from ndrnour July 20, 2022 14:58
@Walcho1125 Walcho1125 dismissed ndrnour’s stale review July 20, 2022 14:59

Nur is no longer part of the project

@juliajulie95 juliajulie95 merged commit bfb8c32 into Catrobat:develop Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliajulie95 juliajulie95 juliajulie95 approved these changes

@Walcho1125 Walcho1125 Walcho1125 approved these changes

@ndrnour ndrnour ndrnour left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khushal1707 @ndrnour @wslany @Walcho1125 @juliajulie95