-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CATROID-1140 Refactor adapter and related files of ScriptFragment to kotlin #4424
Conversation
catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt
Outdated
Show resolved
Hide resolved
catroid/src/main/java/org/catrobat/catroid/ui/dragndrop/BrickListView.kt
Outdated
Show resolved
Hide resolved
catroid/src/main/java/org/catrobat/catroid/ui/dragndrop/BrickListView.kt
Show resolved
Hide resolved
catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt
Outdated
Show resolved
Hide resolved
catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/adapter/BrickAdapter.kt
Outdated
Show resolved
Hide resolved
834db99
to
96ba12b
Compare
87bbcd3
to
72ef751
Compare
Currently the test |
cb3215d
to
18151b4
Compare
We've managed to fix the test with @mseiser. The test happened to be in the wrong folder. |
18151b4
to
e755206
Compare
e755206
to
fc4d524
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, review done in PP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Ticket: https://jira.catrob.at/browse/CATROID-1140
Refactored BrickAdapter, BrickListView and BrickAdapterInterface to kotlin
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.