Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1140 Refactor adapter and related files of ScriptFragment to kotlin #4424

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

bengaal
Copy link
Contributor

@bengaal bengaal commented Jan 21, 2022

Ticket: https://jira.catrob.at/browse/CATROID-1140

Refactored BrickAdapter, BrickListView and BrickAdapterInterface to kotlin

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@bengaal bengaal force-pushed the CATROID-1140 branch 3 times, most recently from 834db99 to 96ba12b Compare July 20, 2022 16:40
@bengaal bengaal force-pushed the CATROID-1140 branch 7 times, most recently from 87bbcd3 to 72ef751 Compare August 22, 2022 08:26
@bengaal
Copy link
Contributor Author

bengaal commented Aug 22, 2022

Currently the test AddBrickFloatingBehaviorTest is failing due to the refactored class BrickAdapter being mocked in the test, which Mockito cannot do, since the Kotlin classes are final by default. One workaround would be to make the class open, but that would be antipattern against Kotlin. I've tried converting the test to Kotlin, but that didn't solve the issue.

@bengaal bengaal force-pushed the CATROID-1140 branch 2 times, most recently from cb3215d to 18151b4 Compare September 14, 2022 08:15
@bengaal
Copy link
Contributor Author

bengaal commented Sep 14, 2022

We've managed to fix the test with @mseiser. The test happened to be in the wrong folder.

Copy link
Contributor

@mseiser mseiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, review done in PP

Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants