Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1339 "Add to backpack" option missing for "Define" bricks #4439

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

friendo97
Copy link
Contributor

@friendo97 friendo97 commented Feb 3, 2022

Definitionbricks for Userdefined Bricks now have the option "add to backpack" in their context menu

https://jira.catrob.at/browse/CATROID-1339

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@bengaal
Copy link
Contributor

bengaal commented Feb 7, 2022

Please consider my suggestion above, otherwise the PR looks good to me.

Copy link
Contributor

@bengaal bengaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes were implemented, looks good to me!

@dandrawes
Copy link
Contributor

Thank you!

@dandrawes dandrawes merged commit d4b0d9e into Catrobat:develop Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants