Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1359 Fix testActivityRecreateRenameSpriteDialog #4444

Merged
merged 1 commit into from
Feb 13, 2022
Merged

CATROID-1359 Fix testActivityRecreateRenameSpriteDialog #4444

merged 1 commit into from
Feb 13, 2022

Conversation

dandrawes
Copy link
Contributor

https://jira.catrob.at/browse/CATROID-1359

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Piki2000
Piki2000 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@Piki2000 Piki2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@juliajulie95
Copy link
Contributor

Thank you!

@juliajulie95 juliajulie95 merged commit 9eef229 into Catrobat:develop Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piki2000 Piki2000 Piki2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dandrawes @juliajulie95 @Piki2000