Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-910 Regex Popup Redesign #4450

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Conversation

mseiser
Copy link
Contributor

@mseiser mseiser commented Feb 10, 2022

CATROID-910

Redesign of Regex Assistant Popup to fit the screenshot in the ticket; Moved link to wiki to "Help" button and resized the Dialog.
Deleted unused Files.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Redesign the Regex Popup according to the Ticket: Moved link to wiki to "Help" button and made dialog smaller.
Copy link
Contributor

@Tamdav Tamdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@juliajulie95
Copy link
Contributor

Thank you!
Looks good, still need to verify test are working on jenkins and waiting on a successful run

@juliajulie95 juliajulie95 merged commit ba343d9 into Catrobat:develop Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants