Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1371 REFACTOR SetBrightnessAction to Kotlin #4465

Merged
merged 1 commit into from
Feb 16, 2023
Merged

CATROID-1371 REFACTOR SetBrightnessAction to Kotlin #4465

merged 1 commit into from
Feb 16, 2023

Conversation

NoQQ
Copy link

@NoQQ NoQQ commented Feb 25, 2022 •
edited
Loading

https://jira.catrob.at/browse/CATROID-1371

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Walcho1125
Walcho1125 requested changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the copyright in the file comment header to 2022 in both files. Other than that everything looks fine!

catroid/src/test/java/org/catrobat/catroid/test/content/actions/SetBrightnessActionTest.kt Outdated
@@ -0,0 +1,110 @@
/*
* Catroid: An on-device visual programming system for Android devices
* Copyright (C) 2010-2018 The Catrobat Team
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (C) 2010-2018 The Catrobat Team
* Copyright (C) 2010-2022 The Catrobat Team

Walcho1125
Walcho1125 approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@juliajulie95
Copy link
Contributor

Please rebase :)

@NoQQ
Copy link
Author

NoQQ commented Jan 10, 2023

Now rebased

Walcho1125
Walcho1125 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again!

@Walcho1125 Walcho1125 merged commit 88a22e7 into Catrobat:develop Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnaribo adnaribo adnaribo approved these changes

@Walcho1125 Walcho1125 Walcho1125 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NoQQ @juliajulie95 @Walcho1125 @adnaribo @JohannesMayerhofer