Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1286 Improve constants names #4492

Merged
merged 1 commit into from
Jul 9, 2022
Merged

CATROID-1286 Improve constants names #4492

merged 1 commit into from
Jul 9, 2022

Conversation

l-ilma
Copy link
Contributor

@l-ilma l-ilma commented Mar 26, 2022

Rename constants in a way that they all follow the same conventions to make them consistent.

https://jira.catrob.at/browse/CATROID-1286

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Walcho1125
Walcho1125 requested changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the changes as discussed on slack!
Changing the copyright header to * Copyright (C) 2010-2022 The Catrobat Team

@l-ilma l-ilma requested a review from Walcho1125 March 28, 2022 13:35
@l-ilma l-ilma force-pushed the CATROID-1286 branch 2 times, most recently from 72ca8fc to 5315f1e Compare March 28, 2022 16:37
Walcho1125
Walcho1125 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wslany
Copy link
Member

wslany commented Apr 18, 2022

Please resolve the conflicts.

@l-ilma
Copy link
Contributor Author

l-ilma commented May 21, 2022

Please resolve the conflicts.

@wslany Conflicts resolved.

@wslany wslany merged commit d435c42 into Catrobat:develop Jul 9, 2022
@wslany
Copy link
Member

wslany commented Jul 9, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliajulie95 juliajulie95 juliajulie95 approved these changes

@Walcho1125 Walcho1125 Walcho1125 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l-ilma @wslany @Walcho1125 @juliajulie95