Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-810 Fix a few linting errors #4501

Merged
merged 1 commit into from
Jul 29, 2022
Merged

CATROID-810 Fix a few linting errors #4501

merged 1 commit into from
Jul 29, 2022

Conversation

l-ilma
Copy link
Contributor

@l-ilma l-ilma commented Apr 3, 2022

Tied to fix a few ignored linting issues. https://jira.catrob.at/browse/CATROID-810

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@l-ilma l-ilma marked this pull request as draft April 3, 2022 13:54
@l-ilma l-ilma force-pushed the CATROID-810 branch 3 times, most recently from be0d652 to 9e8019f Compare May 5, 2022 10:57
@l-ilma l-ilma marked this pull request as ready for review May 5, 2022 10:58
@l-ilma l-ilma force-pushed the CATROID-810 branch 3 times, most recently from af12999 to dfa8632 Compare May 22, 2022 10:14
juliajulie95
juliajulie95 requested changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@juliajulie95 juliajulie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please have a look :)

catroid/src/main/java/org/catrobat/catroid/io/StorageOperations.java Outdated Show resolved Hide resolved
catroid/src/main/java/org/catrobat/catroid/io/StorageOperations.java Outdated Show resolved Hide resolved
catroid/src/main/java/org/catrobat/catroid/stage/SpeechRecognitionHolder.kt Outdated Show resolved Hide resolved
catroid/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml Outdated Show resolved Hide resolved
catroid/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
catroid/config/lint-baseline.xml Outdated Show resolved Hide resolved
@l-ilma l-ilma force-pushed the CATROID-810 branch 7 times, most recently from 5fb4db3 to ba9007b Compare July 12, 2022 18:23
@l-ilma
Copy link
Contributor Author

l-ilma commented Jul 12, 2022

As discussed, please have a look :)

Please check my changes again 👍

@l-ilma l-ilma requested a review from juliajulie95 July 12, 2022 18:40
juliajulie95
juliajulie95 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@juliajulie95 juliajulie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you! 😄

@juliajulie95
Copy link
Contributor

Info for reviewers:
I discussed the remaining linting warnings with @l-ilma and tickets for those are already created.
The goal here was to eliminate easier ones 👍

Walcho1125
Walcho1125 requested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the remark

catroid/config/lint-baseline.xml Outdated Show resolved Hide resolved
@l-ilma
Copy link
Contributor Author

l-ilma commented Jul 28, 2022 •
edited
Loading

Please look at the remark

@Walcho1125 Oh, since this file was auto-generated I forgot to insert the remark. I fixed this now, can you have another look please?

@l-ilma l-ilma requested a review from Walcho1125 July 28, 2022 15:45
Walcho1125
Walcho1125 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@Walcho1125 Walcho1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Walcho1125 Walcho1125 merged commit 6fbc65b into Catrobat:develop Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliajulie95 juliajulie95 juliajulie95 approved these changes

@Walcho1125 Walcho1125 Walcho1125 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l-ilma @juliajulie95 @Walcho1125